Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement settings config features #307

Merged
merged 7 commits into from
Feb 9, 2021

Conversation

Sirmorrison
Copy link
Contributor

@Sirmorrison Sirmorrison commented Jan 30, 2021

Fix #295
This PR implement the following settings page functionality

  • Spend unconfirmed
  • Beep for new blocks
  • Connect to specific peer
  • User agent

@Sirmorrison Sirmorrison marked this pull request as ready for review January 30, 2021 09:11
* implement connect to peer add, update, remove functionality
* implement beep for new block functionality
@Sirmorrison Sirmorrison force-pushed the setting_config branch 2 times, most recently from 8ab88be to 917a91b Compare January 31, 2021 05:16
* cleanup settings code
* rebase pr
@oshorefueled
Copy link
Contributor

The editor placeholder and label seems to be incorrect for change specific peer
Screenshot 2021-01-31 at 17 05 49

wallet/commands.go Outdated Show resolved Hide resolved
ui/settings_page.go Outdated Show resolved Hide resolved
* fix incorrect specific peer editor label text
@Sirmorrison Sirmorrison force-pushed the setting_config branch 2 times, most recently from 5794ec7 to 903a100 Compare February 6, 2021 08:28
* remove reminder dialog from user agent and connect to peer
* rename user agent to custom user agent
* add user agent placeholder when its set
* implement wallet setting beep for new blocks
* set beeep notification frequency and timing to 5,1
@oshorefueled oshorefueled merged commit 3313756 into planetdecred:master Feb 9, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
* update connect to peer ui to use switch widget
* implement connect to peer add, update, remove functionality
* implement beep for new block functionality
* add remove connect to peer alert info modal
* implement user agent functionality
* remove reminder dialog from user agent and connect to peer
* implement wallet setting beep for new blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings page
2 participants