-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement settings config features #307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
511cb98
to
cb47ccd
Compare
* implement connect to peer add, update, remove functionality * implement beep for new block functionality
8ab88be
to
917a91b
Compare
* cleanup settings code * rebase pr
917a91b
to
eb042d4
Compare
oshorefueled
suggested changes
Jan 31, 2021
* fix incorrect specific peer editor label text
5794ec7
to
903a100
Compare
* remove reminder dialog from user agent and connect to peer * rename user agent to custom user agent * add user agent placeholder when its set * implement wallet setting beep for new blocks * set beeep notification frequency and timing to 5,1
903a100
to
fd176ce
Compare
oshorefueled
approved these changes
Feb 9, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* update connect to peer ui to use switch widget * implement connect to peer add, update, remove functionality * implement beep for new block functionality * add remove connect to peer alert info modal * implement user agent functionality * remove reminder dialog from user agent and connect to peer * implement wallet setting beep for new blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #295
This PR implement the following settings page functionality