update wallet page to new mock up ui #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
force-pushed
the
wallet_newui
branch
2 times, most recently
from
7099b80 to
7f4221b
Compare
Sirmorrison
force-pushed
the
wallet_newui
branch
from
7f4221b to
e7f18d3
Compare
oshorefueled
suggested changes
Dec 18, 2020
|
The buttons to backup wallet seeds on the wallet page don't seem to be responsive |
ui/account_info_page.go
Outdated
Comment on lines
177
to
181
| mainLabel := pg.theme.Body1(sMain) | ||
| subLabel := pg.theme.Caption(sSub) | ||
| inset := layout.Inset{ | ||
| Top: values.MarginPadding5, | ||
| } |
There was a problem hiding this comment.
can this balance layout be made a method that can be used by any view that displays amount in DCR? An example is the overview page which displays the balance inconsistently.
There was a problem hiding this comment.
Lets open an issue for this.
The feature to backup wallet has not been Implemented... I left a comment to this effect. |
oshorefueled
suggested changes
Dec 19, 2020
Sirmorrison
force-pushed
the
wallet_newui
branch
2 times, most recently
from
3eaf477 to
9351fc9
Compare
Sirmorrison
force-pushed
the
wallet_newui
branch
4 times, most recently
from
7551402 to
d938d4d
Compare
oshorefueled
suggested changes
Dec 25, 2020
ui/window.go
Outdated
| @@ -54,7 +55,7 @@ type Window struct { | |||
| clipboard chan interface{} | |||
| toast chan *toast | |||
| modal chan *modalLoad | |||
| sysDestroyWithSync bool | |||
| // sysDestroyWithSync bool | |||
There was a problem hiding this comment.
remove commented code
|
The collapsed and expanded icons are not the same with what's in the mockup. Also the balance next to the menu button is not properly aligned with the menu button. Current implementation Correct implementation
|
Sirmorrison
force-pushed
the
wallet_newui
branch
3 times, most recently
from
0e88c55 to
292f108
Compare
oshorefueled
suggested changes
Dec 29, 2020
oshorefueled
previously approved these changes
Dec 29, 2020
Sirmorrison
force-pushed
the
wallet_newui
branch
from
67cc0a6 to
ab40dd4
Compare
Sirmorrison
force-pushed
the
wallet_newui
branch
from
ab40dd4 to
7df8a2a
Compare
* Add account details page with dummy data * Make collapse Button, IsExpanded variables global
* Add more btn to collapsible widget
* Add support for multiple card raduis orientation
Add footer to collapsible widget
* implement redirect to wallet subpage
* Clean up tx details and wallet page codes * Rename account_info to account_info_page * Add chevron icon to collapsible widget * Align collapsible widget more icon
* Add collapsiblewithoption struct and layout * Enhance card widget to use dynamic raduis params
* Restore edit account functionality * Restore create account functionality
* Remove excess padding on wallet page, cleanup code
* Update collapse icon to mockup icon * Fix collapse header content alignment
* Remove commented lines of code * Set selected wallet data for wallet sub pages
* Change card int type raduis params to float type
Sirmorrison
force-pushed
the
wallet_newui
branch
from
7df8a2a to
c91880c
Compare
oshorefueled
approved these changes
Dec 30, 2020
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Fix wallet collapse expansion bug on click * Add account details page with dummy data * Enhance collapsible widget with more button * Add more option data to wallet collapsible widget * Restore create new wallet feature * Add wallet account details page * Add collapsiblewithoption struct and layout * Enhance card widget to use dynamic raduis params * Restore omitted functionalities after new UI update * Add collapsible widget with option to testapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
The pr updates wallet page to new wallet page ui.