-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show politeia proposals #715
Conversation
- fix notification - Add a share button and open the browser in the proposal detail screen
Decred Wallet/Assets.xcassets/more_menu/ic_politeia.imageset/Contents.json
Outdated
Show resolved
Hide resolved
Decred Wallet/Assets.xcassets/more_menu/ic_politeia.imageset/Contents.json
Outdated
Show resolved
Hide resolved
Decred Wallet/Assets.xcassets/more_menu/ic_politeia.imageset/Contents.json
Outdated
Show resolved
Hide resolved
remove empty line Co-authored-by: Abubakar Suleiman <abubakars29@yahoo.com>
Decred Wallet/Features/Navigation Menu/NavigationMenuTabBarController.swift
Outdated
Show resolved
Hide resolved
- Check wallet online when syncing politeia
Fix conflicts: Decred Wallet/Features/Overview/Overview.storyboard
fix Conflicts: Decred Wallet/DcrlibwalletTypes/Transaction.swift
Decred Wallet/Features/More/More Features/Politeia/Politeia.storyboard
Outdated
Show resolved
Hide resolved
Decred Wallet/Features/More/More Features/Politeia/PoliteiaController.swift
Show resolved
Hide resolved
Decred Wallet/Features/More/More Features/Politeia/PoliteiaController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the proposal details page, remove the text in the center of the vote bar, it has been removed as well on android
Also, rename the title of the proposal details page, see suggestion below
This problem still seems to be occurring, see screenshot below If you are certain the issue isn't from the ios code, then it might be worth bringing up in the dcrlibwallet room so it can be properly looked at |
@JustinBeBoy This still hasn't been addressed |
When there's no proposal for a category the message should say "No proposals for selected category" |
Requires planetdecred/dcrlibwallet#170
This PR allows users to:
How the notifications work:
When the client launches the app for the first time, a sync is initiated and all proposals are fetched, now when next the client launches the app the sync initiates again, and if there are new proposals or changes to the proposals fetched initially, our callback listeners are triggered
We have listeners for onNewProposal, onVoteStarted, and onVoteEnded . When any of the listeners are triggered, it sends the appropriate notification to the client
When the client taps on a particular notification, it takes them to the proposal details page for that particular proposal
Screenshots