Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show politeia proposals #715

Merged
merged 25 commits into from
Apr 6, 2021
Merged

Conversation

JustinBeBoy
Copy link
Contributor

@JustinBeBoy JustinBeBoy commented Sep 3, 2020

Requires planetdecred/dcrlibwallet#170

This PR allows users to:

  • Add Proposal politeia in setting
  • View list proposal politeia
  • View detail proposal politeia
  • Set up receiving notifications (new proposal, starting and ending votes)
  • Share and open proposal politeia in browser

How the notifications work:

When the client launches the app for the first time, a sync is initiated and all proposals are fetched, now when next the client launches the app the sync initiates again, and if there are new proposals or changes to the proposals fetched initially, our callback listeners are triggered

We have listeners for onNewProposal, onVoteStarted, and onVoteEnded . When any of the listeners are triggered, it sends the appropriate notification to the client

When the client taps on a particular notification, it takes them to the proposal details page for that particular proposal

Screenshots

- fix notification
- Add a share button and open the browser in the proposal detail screen
@JustinBeBoy JustinBeBoy changed the title show proposal politeia show politeia proposals Sep 3, 2020
Decred Wallet/DcrlibwalletTypes/Politeia.swift Outdated Show resolved Hide resolved
Decred Wallet/DcrlibwalletTypes/Politeia.swift Outdated Show resolved Hide resolved
Decred Wallet/DcrlibwalletTypes/PoliteiaStatus.swift Outdated Show resolved Hide resolved
Decred Wallet/DcrlibwalletTypes/Response.swift Outdated Show resolved Hide resolved
Decred Wallet/Extensions/PlainHorizontalProgressBar.swift Outdated Show resolved Hide resolved
Decred Wallet/zh-Hans.lproj/Localizable.strings Outdated Show resolved Hide resolved
Decred Wallet/pl.lproj/Localizable.strings Outdated Show resolved Hide resolved
Decred Wallet/Custom Views/LoadingView.swift Outdated Show resolved Hide resolved
Decred Wallet/Custom Views/LoadingView.swift Outdated Show resolved Hide resolved
Decred Wallet/Extensions/Dcrlibwallet.swift Show resolved Hide resolved
Decred Wallet/Extensions/Dcrlibwallet.swift Show resolved Hide resolved
Decred Wallet/Extensions/Dcrlibwallet.swift Show resolved Hide resolved
Decred Wallet/Extensions/Dcrlibwallet.swift Outdated Show resolved Hide resolved
Decred Wallet/pl.lproj/Localizable.strings Outdated Show resolved Hide resolved
Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Approved and Rejected Proposals should have the vote bar. Both in the proposal list page and the proposal details page

Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the proposal list page, modify the info in the votebar to look like this
Screenshot from 2021-02-26 21-18-12

Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a proposal under the voting category with a label of approved, please check it out, to ensure syncing is happening properly

Screenshot from 2021-02-26 21-32-34

Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some padding to the drop down menu, take a look at the transactions page for reference

Screenshot from 2021-02-26 21-38-50

Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the proposal details page, remove the text in the center of the vote bar, it has been removed as well on android

Also, rename the title of the proposal details page, see suggestion below

Decred Wallet/en.lproj/Localizable.strings Outdated Show resolved Hide resolved
@dreacot
Copy link
Contributor

dreacot commented Mar 1, 2021

Only Approved and Rejected Proposals should have the vote bar. Both in the proposal list page and the proposal details page

This issue still seems to be there!
steps to replicate

  1. go to the politeia page
  2. switch to approved category
  3. then switch to abandoned category, the vote bar still shows

@dreacot
Copy link
Contributor

dreacot commented Mar 1, 2021

I can see a proposal under the voting category with a label of approved, please check it out, to ensure syncing is happening properly

Screenshot from 2021-02-26 21-32-34

This problem still seems to be occurring, see screenshot below

Screenshot from 2021-03-01 15-16-12

If you are certain the issue isn't from the ios code, then it might be worth bringing up in the dcrlibwallet room so it can be properly looked at

@dreacot
Copy link
Contributor

dreacot commented Mar 3, 2021

I can see a proposal under the voting category with a label of approved, please check it out, to ensure syncing is happening properly
Screenshot from 2021-02-26 21-32-34

This problem still seems to be occurring, see screenshot below

Screenshot from 2021-03-01 15-16-12

If you are certain the issue isn't from the ios code, then it might be worth bringing up in the dcrlibwallet room so it can be properly looked at

@JustinBeBoy This still hasn't been addressed

@dreacot
Copy link
Contributor

dreacot commented Mar 3, 2021

When there's no proposal for a category the message should say "No proposals for selected category"

@macsleven macsleven merged commit c28d770 into planetdecred:master Apr 6, 2021
@JustinBeBoy JustinBeBoy deleted the politeia branch August 23, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants