Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New README.md for llvm_version.txt #938

Merged
merged 2 commits into from
Jun 24, 2024
Merged

New README.md for llvm_version.txt #938

merged 2 commits into from
Jun 24, 2024

Conversation

rengolin
Copy link
Contributor

Fixes #936

@rengolin rengolin requested a review from rolfmorel June 24, 2024 11:02
build_tools/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@adam-smnk adam-smnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@rolfmorel
Copy link
Contributor

Thanks for the explanation and documenting it in-repo, @rengolin!

It will take some time to become acquainted with the development experience laid out in this document (e.g. I am new to git worktree). All the more, thanks for spelling it out.

(When working this way, I'll try to see if I can address the question for myself if saving the commit id in a .txt is really that different from just having it in a .gitmodules file. That is, as far as I understand, a git submodule does not commit you to certain workflows. You could just use it to document a current designated commit for some other project somewhere else (though it has a default location according to .gitmodules) . Maybe there's too much baggage associated with git submodules to go this route anyway.)

@rengolin
Copy link
Contributor Author

FYI, we're not the only ones using this method. StableHLO does a similar thing.

@rengolin rengolin merged commit a16070d into main Jun 24, 2024
14 checks passed
@rengolin rengolin deleted the llvm_version_readme branch June 24, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_tools/llvm_version.txt vs llvm-project as a submodule?
3 participants