Tile configuration addition pass #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KavithaTipturMadhu
force-pushed
the
tileconfig
branch
from
68fba75
to
b6137c5
Compare
adam-smnk
reviewed
Feb 26, 2024
KavithaTipturMadhu
force-pushed
the
tileconfig
branch
from
b6137c5
to
951f7e5
Compare
|
@KavithaTipturMadhu On a second thought on the sames and what might have created also confusion on @adam-smnk side: l suggest renaming TileConfig to IntelAMXTileConfig in both pass names, etc. Then it;s clear this has nothing to do with tiling in general but with Intel AMX in particular. |
KavithaTipturMadhu
force-pushed
the
tileconfig
branch
from
c106d68
to
49bbe8f
Compare
KavithaTipturMadhu
force-pushed
the
tileconfig
branch
from
49bbe8f
to
a6134d6
Compare
rengolin
approved these changes
Mar 1, 2024
rengolin
added
benchmark
adam-smnk
reviewed
Mar 1, 2024
nhasabni
pushed a commit
that referenced
this pull request
Mar 14, 2024
Test cases to be added, draft PR in progress. Runtime and code changes are done, licm hoisting is incomplete, working on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases to be added, draft PR in progress. Runtime and code changes are done, licm hoisting is incomplete, working on it.