Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require expected rank in isInVnniLayout #809

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Require expected rank in isInVnniLayout #809

merged 1 commit into from
Nov 27, 2023
+23 −7

Commits on Nov 27, 2023

  1. Require expected rank in isInVnniLayout 

    Until we have a better way to express the VNNI layout (see: plaidml#563), it is
up to the callee to specify the expected rank in the VNNI layout as the
rank depends on the operations we are dealing with. The current check
for rank < 3 is not correct; this is still ugly, but at least more
explicit, as there are not magic assumptions on rank.
    @chelini
    chelini committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    57b9603 View commit details
    Browse the repository at this point in the history