Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-Tag Support #14

Closed
amattu2 opened this issue Feb 9, 2023 · 1 comment · Fixed by #15
Closed

E-Tag Support #14

amattu2 opened this issue Feb 9, 2023 · 1 comment · Fixed by #15
Assignees
@amattu2
Labels
enhancement New feature or request

Comments

@amattu2
Copy link
Member

amattu2 commented Feb 9, 2023 •
edited
Loading

Description

Add support for HTTP E-Tag headers. Use a quick hash mechanism comprised of the generation attributes (e.g. width/height/colors). Additionally, force Cloudflare to cache based on the E-Tag, not query params.

Code

e.g.

https://github.com/wtg/shuttletracker/blob/cb43c44a4d1dc08f0c8d699f094d6b05a2541c33/api/etag.go#L35

Design Preview(s)

N/A
@amattu2 amattu2 added the enhancement New feature or request label Feb 9, 2023
@amattu2 amattu2 self-assigned this Feb 9, 2023
amattu2 added a commit that referenced this issue Feb 10, 2023
@amattu2
#14 Add E-Tag Support
066d380
@amattu2
Copy link
Member Author

amattu2 commented Feb 10, 2023

  • Pending test cases for etag middleware
  • Replace MD5 with something faster

amattu2 added a commit that referenced this issue Feb 12, 2023
@amattu2
#14 Add E-Tag tests
5508d37
amattu2 added a commit that referenced this issue Feb 12, 2023
@amattu2
#14 Implement SHA1 instead of MD5
1669429
amattu2 added a commit that referenced this issue Feb 12, 2023
@amattu2
#14 Remove weak match prefix
5c5e9d0
amattu2 added a commit that referenced this issue Feb 15, 2023
@amattu2
#14 Remove ETag from non-image gen routes
805a83c
@amattu2 amattu2 linked a pull request Feb 15, 2023 that will close this issue
#14 Add E-Tag Header Support #15
Merged
amattu2 added a commit that referenced this issue Feb 18, 2023
@amattu2
Merge pull request #15 from placeholder-app/amattu2/issue14
529875d 
#14 Add E-Tag Header Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amattu2 amattu2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#14 Add E-Tag Header Support placeholder-app/backend
1 participant
@amattu2