Skip to content

Commit

Permalink
Build Windows AppX package
Browse files Browse the repository at this point in the history 
AppX packages provide filesystem isolation and allow distribution on the Microsoft Store

Signed-off-by: Tom Plant <tom@tplant.com.au>
  • Loading branch information
@pl4nty
pl4nty committed Apr 2, 2024
1 parent 53d16fc commit aa18920
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: windows
path: release/*.exe
path: |
release/*.exe
release/*.appx
sticker-creator:
name: Sticker Creator
Expand Down
6 changes: 5 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -420,13 +420,17 @@
".node"
],
"target": [
"nsis"
"nsis",
"appx"
]
},
"nsis": {
"deleteAppDataOnUninstall": true,
"differentialPackage": true
},
"appx": {
"applicationId": "org.whispersystems.signaldesktop"
},
"linux": {
"category": "Network;InstantMessaging;Chat",
"desktop": {
Expand Down

10 comments on commit aa18920

@RokeJulianLockhart
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall this be posted at /releases? I'd like to know where to track this, so that I can update the URI to the installer file at WinGet to use this.

However, why did you choose AppX over MSIX? That's a deprecated format.

@pl4nty
Copy link
Owner Author

@pl4nty pl4nty commented on aa18920 Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RokeJulianLockhart Please don't upload this to winget, it's only for testing on an upstream PR. It's not synced with upstream, doesn't have a publicly-trusted signature, and has a few branding and auto-update bugs.

Do you have an official source for AppX deprecation? MSIX is backwards compatible, so you can just change the file extension. I didn't need any MSIX-only features, and they're not supported by electron-builder anyway

EDIT: just tested, it's so far behind upstream that it can't send messages anymore

@RokeJulianLockhart
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa18920#commitcomment-143912174

@pl4nty, thanks for the explanation. Explains why it's not a PR. Hopefully there shall be a proper effort to make an MSIX at some point.

@pl4nty
Copy link
Owner Author

@pl4nty pl4nty commented on aa18920 Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I mentioned AppX upstream to gauge interest. but the maintainers haven't responded, so I'm hesitant to spend time on a separate PR

@RokeJulianLockhart
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was suggested at signalapp#1946 (comment), but it seems that they went with merely allowing a developer of the platform to upload their .exe to the Store instead. We could try using WOA-Project/WoA-Installer-Rpi#25 (comment) and seeing whether it provides it repackaged as an MSIX.

@pl4nty
Copy link
Owner Author

@pl4nty pl4nty commented on aa18920 Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the store app mentioned there is a different signal-compatible client, rather than a repack
but you could try downloading it here: https://msft-store.tplant.com.au

@RokeJulianLockhart
Copy link

@RokeJulianLockhart RokeJulianLockhart commented on aa18920 Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa18920#commitcomment-143915983

@pl4nty, that's superb! Thank you. I'd been looking for a FOSS alternative to RG-AdGuard.

@SebCT
Copy link

@SebCT SebCT commented on aa18920 Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome to get a secure MSIX instead of the non-signed Nullsoft Installer from the EXE Installer - very important step for Applocker and WDAC Application Allowlisting! 👍🏻🙏🏻

@RokeJulianLockhart

This comment was marked as outdated.

Sign in to view

@RokeJulianLockhart
Copy link

@RokeJulianLockhart RokeJulianLockhart commented on aa18920 Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa18920#commitcomment-144133323

@SebCT, https://community.signalusers.org/t/provide-an-msix-package/61772?u=rokejulianlockhart

Please sign in to comment.