Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission title/subtitle html text quirk #9773

Closed
touhidurabir opened this issue Mar 6, 2024 · 5 comments
Closed

Submission title/subtitle html text quirk #9773

touhidurabir opened this issue Mar 6, 2024 · 5 comments
Assignees
@touhidurabir
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.4.0-6

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Mar 6, 2024 •
edited
Loading

Describe the bug
In #2564, submission title and subtitle got new enhancement which allow limited number of html tags/elements into this field which is possible to apply via editor toolbar or as text like Some <b>Bold</b> text . However this leads to allow adding any kind of html and sometime those don't get parsed well . This does not pose any Cross-site scripting (XSS) issue as that being handled well but causing broken title or subtitle .

To Reproduce
Steps to reproduce the behavior:

  1. Start a new submission or edit a submission that has reached to production stage
  2. Add/Edit the title/subtitle field with invalid html e.g. Some <b>Bold</b> text <img src="error" onerror=alert(1)>
  3. See that title and subtitle bit broken due to invalid html tags/elements

What application are you using?
OJS, OMP or OPS version 3.4.0 and main

PRs

Stable-3.4.0

pkp-lib --> #9774
ui-library --> pkp/ui-library#335
ojs --> pkp/ojs#4205 [TEST ONLY]

Main

pkp-lib --> #10025
ui-library --> pkp/ui-library#361
ojs --> pkp/ojs#4303 [TEST ONLY]
@touhidurabir touhidurabir self-assigned this Mar 6, 2024
@touhidurabir touhidurabir added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Mar 6, 2024
@touhidurabir touhidurabir added this to the 3.4.0-6 milestone Mar 6, 2024
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 6, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for rich field text
ee983ff
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 6, 2024
@touhidurabir
pkp#9773 html text enhancement for title and subtitle
0452ebb
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 6, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for title and subtitle
c2867ab
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 6, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
a75afdb
This was referenced Mar 6, 2024
Merged
Merged
Open
@touhidurabir
Copy link
Member Author

@asmecher can you take a look at the PRs at #9773 (comment) .

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 8, 2024
@touhidurabir
pkp#9773 removed ability to enter formatting as text and parsed as fo…
c92f997 
…rmate
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 8, 2024
@touhidurabir
pkp/pkp-lib#9773 removed ability to enter formatting as text and pars…
5145eeb 
…ed as formate
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 8, 2024
@touhidurabir
pkp/pkp-lib#9773 removed added underscore js package
2ae6fcf
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 8, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
76bfd9f
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 8, 2024
@touhidurabir
pkp#9773 code cleanup
f299c90
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 8, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
a205812
@touhidurabir
Copy link
Member Author

@asmecher if test pass , please review the PRs at #9773 (comment) , need forward porting to main .

@asmecher
Copy link
Member

asmecher commented Mar 9, 2024

Reviewed, thanks, @touhidurabir; see pkp/ui-library#335

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 9, 2024
@touhidurabir
pkp#9773 code cleanup
c38f314
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 9, 2024
@touhidurabir
pkp/pkp-lib#9773 typo fixed
79e620e
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 9, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
d794fe1
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 9, 2024
@touhidurabir
pkp#9773 code cleanup
20fe72c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 9, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
ba40ac3
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 removed rich text field associated tinymce paste_pre…
9c24d10 
…process method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
455c845
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 7, 2024
@touhidurabir
pkp#9773 html text enhancement for title and subtitle
6bdee23
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 7, 2024
@touhidurabir
pkp#9773 removed ability to enter formatting as text and parsed as fo…
d37c4a0 
…rmate
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 7, 2024
@touhidurabir
pkp#9773 code cleanup
9d4bd9c
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 7, 2024
@touhidurabir
pkp#9773 code cleanup
7a2cd23
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 7, 2024
@touhidurabir
pkp#9773 code cleanup
d07905f
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for rich field text
9f34dd2
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 removed ability to enter formatting as text and pars…
e72839e 
…ed as formate
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 typo fixed
108e81f
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 removed rich text field associated tinymce paste_pre…
68f3a9f 
…process method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
1923b19
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for title and subtitle
9e93edf
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_stable_3_4_0##
b40c06a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 removed added underscore js package
4792914
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for rich field text
ff18d10
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 7, 2024
@touhidurabir
pkp#9773 html text enhancement for title and subtitle
75ac488
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 Submodule Update ##touhidurabir/i9773_main##
1f7d9d1
This was referenced Jun 7, 2024
Merged
Merged
Open
asmecher pushed a commit to pkp/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for rich field text (#335)
9c36e43 
* pkp/pkp-lib#9773 html text enhancement for rich field text

* pkp/pkp-lib#9773 removed ability to enter formatting as text and parsed as formate

* pkp/pkp-lib#9773 typo fixed

* pkp/pkp-lib#9773 removed rich text field associated tinymce paste_preprocess method
asmecher pushed a commit that referenced this issue Jun 7, 2024
@touhidurabir
#9773 html text enhancement for title and subtitle (#9774)
2def21b 
* #9773 html text enhancement for title and subtitle

* #9773 removed ability to enter formatting as text and parsed as formate

* #9773 code cleanup

* #9773 code cleanup

* #9773 code cleanup
asmecher pushed a commit that referenced this issue Jun 7, 2024
@touhidurabir
#9773 html text enhancement for title and subtitle (#10025)
b177d67
asmecher pushed a commit to pkp/ui-library that referenced this issue Jun 7, 2024
@touhidurabir
pkp/pkp-lib#9773 html text enhancement for rich field text (#361)
70e8c13
@asmecher
Copy link
Member

asmecher commented Jun 7, 2024

Thanks, @touhidurabir! I've merged the 4 PRs (and will update the application submodules manually). Is this ready to be closed?

@touhidurabir
Copy link
Member Author

@asmecher yeah, it's all done . I am closing this now .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.4.0-6
Development

No branches or pull requests
2 participants
@asmecher @touhidurabir