Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site-wide plugins can be enabled/disabled from the context's plugin grid #6351

Closed
NateWr opened this issue Nov 18, 2020 · 2 comments
Closed
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.

Comments

@NateWr
Copy link
Contributor

NateWr commented Nov 18, 2020

Describe the bug
The Usage Statistics plugin is a site-wide plugin, however, it can be enabled and disabled from the context's plugin grid. This means that a journal manager could disable the plugin even though it should only be possible to do this from the admin area.

The settings form can be saved with different settings for each context, so that needs to be accessible to managers. But it should not be possible to disable this plugin except from the admin area.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings > Website > Plugins.
  2. Click to active/deactivate the Usage Statistics plugin.
  3. See the enabled setting in plugin_settings has been changed.

What application are you using?
3.3 pre-release (master)

@NateWr NateWr added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Nov 18, 2020
NateWr added a commit to NateWr/usageStats that referenced this issue Nov 25, 2020
@NateWr
Copy link
Contributor Author

NateWr commented Nov 25, 2020

The following PR splits the settings management of the usage stats plugin at site/context level. At site level all settings are available and the admin can enable/disable the plugin. At the context level it can not be enabled/disabled, and only the bar chart settings can be configured.

cc @bozana, @ctgraham is that ok?

PR:
pkp/usageStats#38

Tests:
pkp/ojs#2918

@NateWr NateWr added this to the OJS/OMP/OPS 3.3 milestone Nov 25, 2020
NateWr added a commit to pkp/usageStats that referenced this issue Nov 26, 2020
pkp/pkp-lib#6351 Separate settings management for site and context le…
@NateWr
Copy link
Contributor Author

NateWr commented Nov 26, 2020

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

1 participant