Include missing MongoDB driver types in production build #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
added
🐛 bug
pkosiec
force-pushed
the
fix-missing-mongodb-types
branch
from
0e754e3 to
1d8041b
Compare
pkosiec
changed the title
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 18 18
Lines 277 277
Branches 51 51
=======================================
Hits 259 259
Misses 7 7
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Mongo Seeding TS types depends on MongoDB driver v3 ones (from
@types/mongodb), they should be included in the production build to avoid compilation errors when using Mongo Seeding with MongoDB v4 driver. See the discussion in #182.Related issues
Resolves #182