Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring EJSON mode while parsing JSON files #143

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Conversation

pkosiec
Copy link
Owner

@pkosiec pkosiec commented Jan 5, 2021

  • Allow configuring EJSON mode while parsing JSON files: from Core, CLI and Docker image
  • Refactor loading options for CLI

Resolves #131

@pkosiec pkosiec added 🚀 enhancement New feature or request area/docker-image Refers to Mongo Seeding Docker Image area/core Refers to Mongo Seeding library area/cli Refers to Mongo Seeding CLI labels Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #143 (2c0766c) into master (b72c791) will decrease coverage by 0.80%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   94.23%   93.43%   -0.81%     
==========================================
  Files          18       18              
  Lines         260      274      +14     
  Branches       46       49       +3     
==========================================
+ Hits          245      256      +11     
  Misses          7        7              
- Partials        8       11       +3     
Flag Coverage Δ
cli 93.75% <88.00%> (-4.29%) ⬇️
core 93.33% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/config.ts 93.75% <ø> (ø)
cli/src/options.ts 92.15% <88.00%> (-5.22%) ⬇️
core/src/populator/filesystem.ts 97.29% <100.00%> (ø)
core/src/populator/populator.ts 82.35% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72c791...2c0766c. Read the comment docs.

@pkosiec pkosiec merged commit 56c57b4 into master Jan 5, 2021
@pkosiec pkosiec deleted the ejson-options branch January 5, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Refers to Mongo Seeding CLI area/core Refers to Mongo Seeding library area/docker-image Refers to Mongo Seeding Docker Image 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring EJSON parsing mode
1 participant