Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to electron #186

Closed
3 of 6 tasks
getneil opened this issue Feb 2, 2023 · 3 comments · Fixed by #187
Closed
3 of 6 tasks

migrate to electron #186

getneil opened this issue Feb 2, 2023 · 3 comments · Fixed by #187
Assignees
@getneil

Comments

@getneil
Copy link
Contributor

getneil commented Feb 2, 2023 •
edited
Loading

Todos:

  • create electron workspace
  • make pipeline build in CI
  • cp gui svelte code to electron/*: mock integration only
  • convert tauri integration and http req into electron-implementation
  • make pipeline build in CD
  • cleanup: rm tauri build in CD
@getneil getneil self-assigned this Feb 2, 2023
getneil pushed a commit that referenced this issue Feb 2, 2023
#186 init electron
0d6336a
@getneil getneil mentioned this issue Feb 2, 2023
Merged
8 tasks
getneil pushed a commit that referenced this issue Feb 2, 2023
#186 init electron ci build
bf48a16
getneil pushed a commit that referenced this issue Feb 3, 2023
#186 cp svelte components into electron. WARNING: doesnt work like th…
f56598b 
…e tauri build yet
getneil pushed a commit that referenced this issue Feb 7, 2023
#186 convert auth into electron setup
957cba2
getneil pushed a commit that referenced this issue Feb 7, 2023
#186 achieve tauri feature parity
39ad639
getneil pushed a commit that referenced this issue Feb 7, 2023
#186 fix vite build for electron main
61ecc1e
getneil pushed a commit that referenced this issue Feb 8, 2023
#186 install package invoke handlr
e61c09b
getneil pushed a commit that referenced this issue Feb 8, 2023
#186 update ci/cd pipeline to build electron
0be8a6d
@waldyrious
Copy link

Out of curiosity, what motivated this migration?

@getneil
Copy link
Contributor Author

getneil commented May 3, 2023

Out of curiosity, what motivated this migration?

We needed to implement a deeplinking feature, tauri does not support deeplinking effectively.

@waldyrious
Copy link

waldyrious commented May 7, 2023 •
edited
Loading

Thanks, that's good to know! For reference, the relevant issue in the Tauri issue tracker is tauri-apps/tauri#323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getneil getneil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Electron migration pkgxdev/ossapp
2 participants
@waldyrious @getneil