Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create command #31

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bjohansebas
Copy link
Contributor

Some things I want to do:

  • Ask if they will use GitHub Pages
  • Ask about the labels they want to monitor
  • GitHub organization or user they want to monitor
  • Ask if they want to add a separate project

@bjohansebas bjohansebas marked this pull request as draft November 29, 2024 05:06
@bjohansebas bjohansebas marked this pull request as ready for review November 30, 2024 02:57
@bjohansebas
Copy link
Contributor Author

The linter issue should be fixed in #28.

@bjohansebas
Copy link
Contributor Author

@wesleytodd do you want me to update the README in this PR or in another one with a better structure?

@bjohansebas
Copy link
Contributor Author

I know I already did this work, but I think it would be better to convert this into a GitHub action instead of a CLI

@wesleytodd
Copy link
Member

I think it would be better to convert this into a GitHub action instead of a CLI

I will take a strong stance on this. Every github action should be a light wrapper around a JavaScript library. And in the case of this one, generating a static site out of a status board is also a reasonable use case where a cli makese sense.

It is common for people to author things like this in a very narrow way that limits it's use, and so I set this package up this way to avoid that fate. Nearly everything we do in OSS is best done as a small stand-alone library first which is wrapped in a UX second, and this is no exception.

I will get on reviewing this code (might be tomorrow at this point), but I just wanted to reply on that point while it was on my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants