Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate out storage of parsed option in results #39

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

shadowspawn
Copy link
Collaborator

Move the code for storing parsed option to its own routine:

The intent is zero changes in functionality, zero bugs fixes, zero changes to conventions.

Copy link
Collaborator

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good refactor, is your thinking that we could then easily move to a Map as suggested in #32?

@bcoe bcoe merged commit 724b55c into pkgjs:main Jan 22, 2022
@shadowspawn
Copy link
Collaborator Author

Yes, refactor simplifies all of:

  • finish move to xor flags/value
  • drop unnecessary arrays in results
  • switch from object to Map for internal logic
  • add support for short flags

@shadowspawn shadowspawn deleted the feature/store-refactor branch February 5, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants