Workflow to automatically update release tag #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Eomm
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
I want to mention that Optic releases to npm only if you set the npm_token.
Regarding the PR there is an open issue for that:
nearform-actions/optic-release-automation-action#13
We could integrate that GHA when this feature will be shipped.
Meanwhile, this GH workflow LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should really be a separate action, but ain't nobody got time for that.
I looked into https://github.com/nearform/optic-release-automation-action, but it seems like it's doing quite a bit, e.g. it needs specifically a PR before a release can be made, it also wants to publish to npm, etc - we don't really need that here, I figure this is good enough?