Run npm ci when a lockfile is available
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Jan 3, 2022
| then | ||
| echo "::set-output name=install-command::npm ci" | ||
| else | ||
| echo "::set-output name=install-command::npm install" |
There was a problem hiding this comment.
yarn support not yet implemented - #6 - it needs a little bit more thought.
There was a problem hiding this comment.
npm install and npm ci both read yarn.lock automatically in npm 7+.
There was a problem hiding this comment.
You think we should run npm ci when yarn.lock is present (until #6 is done)?
There was a problem hiding this comment.
Yes, that would make the most sense.
npm supports this as of v7+ and it is a better option than `npm install` until #6 is implemented
ljharb
approved these changes
Jan 4, 2022
Eomm
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8.
Doing this as a separate step, because I'd like to keep the default shell (Powershell on Windows) for the actual install step (I suspect we'll have to make it configurable, but that's out of scope here - will wait for someone to ask for that).
Test runs: