Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SandboxCallCheck: new check for invalid sandbox calls #648

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

arthurzam
Copy link
Member

@ulm, I've written the check. On commit gentoo/gentoo@fb8ecab it did catch your 2 examples, and on master it catches nothing (good news).

Catches multiple arguments passed to function, and colon separated path.

Resolves: #644

@arthurzam arthurzam requested a review from thesamesam January 13, 2024 09:49
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Catches multiple arguments passed to function, and colon separated path.

Resolves: pkgcore#644
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@gentoo-bot gentoo-bot merged commit 4007f00 into pkgcore:master Jan 14, 2024
8 checks passed
@arthurzam arthurzam deleted the sandbox branch January 14, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Check]: Warn about colon-separated argument in sandbox functions
3 participants