perf: added error Handling for homepage component #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It introduces error handling for useCurrentUser errors, adds a loading state, implements an authentication redirect, and improves code organization.
|
Thank you for following the naming conventions! 🙏 |
HarshMN2345
changed the title
HarshMN2345
changed the title
Comment on lines
+15
to
+23
| if (error) { | ||
| setErrorMessage('An error occurred while fetching user data. Please try again later.') | ||
| } | ||
|
|
||
| if (user && !isLoading) { | ||
| router.replace('/dashboard') | ||
| } | ||
|
|
||
| if (!user && !isLoading) { |
There was a problem hiding this comment.
Hi @HarshMN2345
Thanks for contributing 😄.
This is the homepage as we would like a Landing page here. We don't want to redirect the user to /dashboard.
Also, the dashboard is at app.localhost:3000/dashboard subdomain 😄
But great code 🎉
|
Also please mention #issue-number in description ✨ |
|
@HarshMN2345 Please update the issue number, You have mentioned wrong issue number |
github-actions
bot
added
🚨 merge conflict
|
Hey there, there is a merge conflict, can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It introduces error handling for useCurrentUser errors, adds a loading state, implements an authentication redirect, and improves code organization.