Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed layout shift on form page change #78

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: fixed layout shift on form page change #78

merged 1 commit into from
Oct 10, 2023

Conversation

thepradipvc
Copy link
Contributor

@thepradipvc thepradipvc commented Oct 8, 2023

What does this PR do?

This PR fixes the layout shift

Fixes #77

app.localhost_3000_dashboard_world_forms_edit_b8212673-ae81-4ff6-8eb1-b57a419a43d4.-.Brave.2023-10-08.15-43-57.mp4
  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Thank you for following the naming conventions! 🙏

@hemantwasthere
Copy link
Collaborator

Hey @ChaudharyPradip, Can you also show me the layout shifting issue in a video

@thepradipvc
Copy link
Contributor Author

I have uploaded it while creating an issue. It's there.

@thepradipvc
Copy link
Contributor Author

I have uploaded it while creating an issue. It's there.

Sorry. I guess there was some issue while uploading the video. I'm uploading it here now.

app.localhost_3000_dashboard_world_forms_edit_a056010d-45c4-4fb2-9eb8-3233d0e1c679.-.Brave.2023-10-10.06-44-23.mp4

@hemantwasthere
Copy link
Collaborator

LGTM 👍

@hemantwasthere hemantwasthere merged commit 7b57888 into piyushgarg-dev:main Oct 10, 2023
5 checks passed
@thepradipvc thepradipvc deleted the fix/fixed-layout-shift-on-form-page-change branch October 10, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Layout shift while navigating between different pages on form edit
2 participants