fix: Resolves the issue regarding copy link in form #53
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
SwastikKasera
changed the title
hemantwasthere
requested changes
Oct 8, 2023
components/Dashboard/FormPane.tsx
Outdated
| @@ -3,7 +3,7 @@ import Image from 'next/image' | |||
| import Link from 'next/link' | |||
| import { useRouter } from 'next/router' | |||
| import { useState } from 'react' | |||
|
|
|||
| import toast from 'react-hot-toast' | |||
There was a problem hiding this comment.
Move the import statement above as we're separating our imports from built-in libs to custom libs
|
Sure, @hemantwasthere. I am working on it |
|
I have implemented the suggestion, please review |
hemantwasthere
requested changes
Oct 10, 2023
components/Dashboard/FormPane.tsx
Outdated
| import Link from 'next/link' | ||
| import { useRouter } from 'next/router' | ||
| import { useState } from 'react' | ||
| import toast from 'react-hot-toast' |
There was a problem hiding this comment.
put a space of a line between the imports
like this:
import Link from 'next/link'
import { useRouter } from 'next/router'
import { useState } from 'react'
// space here
import { Checkbox } from '@/components/ui/checkbox'
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from '@/components/ui/tooltip'
gql/graphql.ts
Outdated
| @@ -73,6 +73,28 @@ export type Form = { | |||
| updatedAt?: Maybe<Scalars['Date']['output']>; | |||
There was a problem hiding this comment.
Discard all the other file changes except FormPane.tsx
github-actions
bot
added
🚨 merge conflict
|
Hey there, there is a merge conflict, can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix the copy button to copy the link of the forms.
Fixes #52
Type of change
Checklist