Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form submition on cancel button #36

Merged

Conversation

ManishPJha
Copy link
Contributor

@ManishPJha ManishPJha commented Oct 7, 2023

What does this PR do?

This PR addresses the issue #34 by fixing the unintended behavior in the "Create Form" modal. Previously, both the "Cancel" and "Continue" buttons were creating a form when the "Cancel" button was clicked. This PR ensures that the form is only created when the "Continue" button is clicked.

Fixes #34
I fixed on cancel button form submition issue by adding type="button" property.

Loom Video: https://www.loom.com/share/d11dcaf9c35046c5afad816e5c91cd46

Requirement/Documentation

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • No special testing configuration is required.
  • Steps to test:
    1. Open the application.
    2. Navigate to the "Create Form" modal.
    3. Enter some data in the form fields.
    4. Click the "Cancel" button.
    5. Click the "Continue" button.

Mandatory Tasks

  • Self-reviewed the code.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Thank you for following the naming conventions! 🙏

@ManishPJha ManishPJha changed the title fixed form submmition on cancel button fixed form submition on cancel button Oct 7, 2023
@ManishPJha ManishPJha changed the title fixed form submition on cancel button fix: form submition on cancel button Oct 7, 2023
@piyushgarg-dev
Copy link
Owner

Great PR + Description 🎉

@piyushgarg-dev piyushgarg-dev added hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 7, 2023
@piyushgarg-dev piyushgarg-dev merged commit b92e7b0 into piyushgarg-dev:main Oct 7, 2023
4 of 6 checks passed
@ManishPJha ManishPJha deleted the fix/form-modal-submition branch October 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Cancel Form Creation Issue
2 participants