Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace the image of vercel on login and signup page with review logo #278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

20santi
Copy link

@20santi 20santi commented Dec 12, 2023

What does this PR do?

Replace vercel logo to review app logo in both signin and signup page

Fixes #276

Screenshot 2023-12-12 145041 Screenshot 2023-12-12 145536

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
review-app ❌ Failed (Inspect) Dec 12, 2023 9:36am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @20santi 😃,

Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.

Copy link

github-actions bot commented Dec 12, 2023

Thank you for following the naming conventions! 🙏

@github-actions github-actions bot added the bug Something isn't working label Dec 12, 2023
@20santi 20santi changed the title Fix: #276 Fix: Replace the image of vercel on login and signup page with review logo Dec 12, 2023
@20santi 20santi changed the title Fix: Replace the image of vercel on login and signup page with review logo fix: Replace the image of vercel on login and signup page with review logo Dec 12, 2023
@20santi
Copy link
Author

20santi commented Dec 12, 2023

Can anyone help me why deployment has failed . I only imported ReviewAppLogo and replaced with vercel logo.

@AnmolDotX
Copy link

Can anyone help me why deployment has failed . I only imported ReviewAppLogo and replaced with vercel logo.

Don't worry about it, it will deploy when your code is merged as deployment only works with the main branch, let @piyushgarg-dev merge this after review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Replace the image of vercel on login and signup page with review logo
2 participants