-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updated contributing doc where env local had different domains #275
docs: Updated contributing doc where env local had different domains #275
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for following the naming conventions! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @ArshadChowdhury 😃,
Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.
Already resolved! |
@hemantwasthere bro the doc is not updated according to new env domain. the previous & current version here is this - NEXT_PUBLIC_AWS_API_URL=http://localhost:8000/local the new version should be this (in this pr) - NEXT_PUBLIC_AWS_API_URL= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you very much, really appreciate it. |
What does this PR do?
Fixes # (issue)
Updated Contributing.md file where it had only one public domain now we have two so had to update the doc accordingly.
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist