fix: landing page hero section button alignment fixed #228
Conversation
|
Thank you for following the naming conventions! 🙏 |
pages/templates/ebraj/index.tsx
Outdated
| @@ -161,7 +161,7 @@ export const HeroSection = () => { | |||
| <div className="h-60 bg-gradient-to-br from-violet-500 to-violet-600 blur-[200px] dark:from-sky-900 dark:to-sky-950"></div> | |||
| <div className="h-60 bg-gradient-to-r from-violet-500 to-violet-600 blur-[200px] dark:from-sky-800 dark:to-sky-900"></div> | |||
| </div> | |||
| <main className="text-center"> | |||
| <main className="text-center flex flex-col"> | |||
There was a problem hiding this comment.
If you had added justify-center items-center here , it would have achieved the same result without the need to make changes to the button. Nevertheless, I believe the output remains consistent in both scenarios👍.
There was a problem hiding this comment.
@tanpreetjolly Can you please do the changes that @sohan9819 recommended instead of current change you have done.
|
LGTM 👍 |
|
Yeah I think you are right, that would achieve the same result without touching the button. |
pages/templates/ebraj/index.tsx
Outdated
| @@ -161,7 +161,7 @@ export const HeroSection = () => { | |||
| <div className="h-60 bg-gradient-to-br from-violet-500 to-violet-600 blur-[200px] dark:from-sky-900 dark:to-sky-950"></div> | |||
| <div className="h-60 bg-gradient-to-r from-violet-500 to-violet-600 blur-[200px] dark:from-sky-800 dark:to-sky-900"></div> | |||
| </div> | |||
| <main className="text-center"> | |||
| <main className="text-center flex flex-col"> | |||
There was a problem hiding this comment.
@tanpreetjolly Can you please do the changes that @sohan9819 recommended instead of current change you have done.
|
All right I will do that |
|
@hemantwasthere I have done the changes you requested please check |
What does this PR do?
It fixes the alignment of landing page button which was overlapping with the text.
Fixes #254
I have used a flex container for the parent container to fix the alignment and layout of the hero section so that the hero button is no longer overlapping
Before :
After :
Type of change
How should this be tested?