Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cursor as pointer for theme toggle dropdown menu items #216

Conversation

Amogh-Nivaskar
Copy link
Contributor

What does this PR do?

Makes the cursor property as pointer for the theme toggle dropdown items, since they are clickable

Fixes #146

Video Demo

https://www.loom.com/share/b98640d571c2435090da6aeb864e6f79

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  1. Login or signup and go to dashboard.
  2. On the upper righthand corner, click on the theme toggle button
  3. Hover on the dropdown items of theme toggle button
  4. You will see that the cursor is set to pointer

@github-actions github-actions bot added the bug Something isn't working label Oct 21, 2023
@github-actions
Copy link

Thank you for following the naming conventions! 🙏

@Amogh-Nivaskar
Copy link
Contributor Author

Amogh-Nivaskar commented Oct 21, 2023

@hemantwasthere this is the new PR I have opened after fixing merge conflicts. Pls do have a look

Copy link
Collaborator

@hemantwasthere hemantwasthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hemantwasthere hemantwasthere merged commit 9eb2853 into piyushgarg-dev:main Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown items for theme toggle has cursor as default
2 participants