Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the color on hovering links in the footer in both Light and Dark Mode #197

Conversation

rushikeshg25
Copy link
Contributor

@rushikeshg25 rushikeshg25 commented Oct 19, 2023

What does this PR do?

Fixes #195

Before on hovering Footer Links in LightMode -->
Screenshot (277)

After fix -->
Screenshot (276)

Requirement/Documentation

  • No Documentation or Requirement

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to the homepage or any page that has Footer
  • Hover on any link in the Footer in both dark and Light Mode

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

@github-actions github-actions bot added the bug Something isn't working label Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Thank you for following the naming conventions! 🙏

@rushikeshg25 rushikeshg25 changed the title Fixed the color on hovering links in the footer fix:Fixed the color on hovering links in the footer Oct 19, 2023
@rushikeshg25 rushikeshg25 changed the title fix:Fixed the color on hovering links in the footer fix: Fixed the color on hovering links in the footer Oct 19, 2023
@rushikeshg25 rushikeshg25 changed the title fix: Fixed the color on hovering links in the footer fix: Fixed the color on hovering links in the footer in both Light and Dark Mode Oct 19, 2023
@rushikeshg25
Copy link
Contributor Author

Hey I have fixed the hover in both Light and dark Mode.

@piyushgarg-dev piyushgarg-dev added good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 19, 2023
@piyushgarg-dev piyushgarg-dev merged commit f16324e into piyushgarg-dev:main Oct 19, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Footer text color changes to lighter color in light mode when hovering
2 participants