fix: Changed footer text color to darker shade on hover in light mode #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
sharmashekhar0
changed the title
|
I think i needed to include some files in gitignore but I am not sure what needs to be in gitingore file. So if there is some change needed just comment that down. |
|
Hey there, there is a merge conflict, can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR simply changes the hover effect of footer items in the light mode. Previously text color changed to "text-gray-100" on hover in light mode which made text almost invisible. This PR fixed this issue and now text color changes to darker shade on hover in light mode and text is clearly visible.
Fixes #195
[Library | Loom - 19 October 2023 - Watch Video](https://www.loom.com/share/882a4d9bdf1e45c39f7d4bba8fc84d89)
Type of change
How should this be tested?
This PR changes just the hover effect on footer items. These changes can be visually test by going to the footer of review app and hovering over footer items.