fix: Error msg and label color fix #189
Conversation
|
Thank you for following the naming conventions! 🙏 |
| @@ -93,7 +93,7 @@ const FormLabel = React.forwardRef< | |||
| return ( | |||
| <Label | |||
| ref={ref} | |||
| className={cn(error && 'text-destructive', className)} | |||
| className={cn(error && 'text-destructive text-white', className)} | |||
There was a problem hiding this comment.
why'd you added text-white here
There was a problem hiding this comment.
to change the color of the Label to white
There was a problem hiding this comment.
but it would look transparent in the light mode
There was a problem hiding this comment.
Yes it's true.
Ok let me check and try to fix it.
Thanks for the information.
| @@ -155,7 +155,7 @@ const FormMessage = React.forwardRef< | |||
| <p | |||
| ref={ref} | |||
| id={formMessageId} | |||
| className={cn('text-sm font-medium text-destructive', className)} | |||
| className={cn('text-sm font-medium text-destructive text-red-600', className)} | |||
There was a problem hiding this comment.
and again why you added text-red-600 here
There was a problem hiding this comment.
to change the color of the error msg to red
There was a problem hiding this comment.
we already have text-destructive class for all the error messages
|
Closing this PR as it doesn't seem to be providing any meaningful contributions. |
What does this PR do?
This PR fixes the Error message and label color in the Sign-Up and login page
Fixes #188
Before ---->
After ---->
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist