Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dark mode and text area bug #16

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

estd20xx
Copy link
Contributor

@estd20xx estd20xx commented Oct 7, 2023

What does this PR do?

Fixes #15

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Thank you for following the naming conventions! 🙏

@estd20xx estd20xx changed the title Fix: Dark mode and text area bug (#15) Dark mode and text area bug (#15) Oct 7, 2023
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Show resolved Hide resolved
@estd20xx estd20xx changed the title Dark mode and text area bug (#15) Dark mode and text area bug Oct 7, 2023
@estd20xx estd20xx changed the title Dark mode and text area bug Bugfix: Dark mode and text area bug Oct 7, 2023
@piyushgarg-dev piyushgarg-dev changed the title Bugfix: Dark mode and text area bug fix: Dark mode and text area bug Oct 7, 2023
@piyushgarg-dev piyushgarg-dev added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 7, 2023
Copy link
Collaborator

@hemantwasthere hemantwasthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware of indentation before committing your code next time else everything looks good. 👍

components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Show resolved Hide resolved
components/Dashboard/ReviewForm.tsx Outdated Show resolved Hide resolved
@hemantwasthere
Copy link
Collaborator

@NamelesssNerd Thanks for your meaningful contributions 😊

@hemantwasthere hemantwasthere merged commit fdb6396 into piyushgarg-dev:main Oct 7, 2023
2 checks passed
@estd20xx estd20xx deleted the Fix/UI-in-dark-mode branch October 8, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode and text area bug
3 participants