Drop explicit webextension-polyfill import
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
webextension-polyfill import
fregante
commented
Mar 29, 2022
| @@ -0,0 +1,3 @@ | |||
| import browser from "webextension-polyfill"; | |||
|
|
|||
| globalThis.browser = browser; | |||
There was a problem hiding this comment.
Required because the polyfill does not automatically set the browser global when bundled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for pixiebrix/pixiebrix-extension#3043
This means that the
webextension-polyfillmust be pre-loaded before thisThe browser tests still pass in Chrome 🎉