Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2870 Map dropdown options. Tests #2963

Merged
merged 4 commits into from
Mar 17, 2022
Merged

#2870 Map dropdown options. Tests #2963

merged 4 commits into from
Mar 17, 2022

Conversation

BALEHOK
Copy link
Contributor

@BALEHOK BALEHOK commented Mar 16, 2022

Closes #2870

With this PR the Dropdown will try to preserve created options when switching between regular and dropdown with labels.
More tests added.

@BALEHOK BALEHOK requested review from BLoe and twschiller March 16, 2022 20:53
}

async function setVarValue() {
// Switch to @var and inset "@data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: insert

@BALEHOK BALEHOK enabled auto-merge (squash) March 17, 2022 12:56
@BALEHOK BALEHOK merged commit c8c8390 into main Mar 17, 2022
@BALEHOK BALEHOK deleted the feature/2870-dd-with-labels branch March 17, 2022 13:01
@twschiller twschiller added this to the 1.5.8 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants