Store cloudAddr in unencrypted JSON data. Simplify logic for updating and resetting plugin settings #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and resetting plugin settings Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit 8aaaef64a46c37a4651d11f9ee5762933ca4cfd6)
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
|
@pixie-io/maintainers could you give this a review when you have the chance? |
vihangm
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Store cloudAddr in unencrypted JSON data. Simplify logic for updating and resetting plugin settings
This addresses #100 (comment). Before this change, all plugin settings were stored in
secureJsonData. This means that all settings, even the non secret ones likecloudAddr, were all encrypted. This prevents the plugin from reading the currently savedcloudAddrback.By storing the
cloudAddrinjsonData, we can show the user the current value of the input field and prevent the confusion linked above.This change also simplifies the config editor component by leveraging the
onUpdateDatasourceJsonDataOption,onUpdateDatasourceSecureJsonDataOptionandupdateDatasourcePluginResetOptionfunctions from Grafana's SDK.Testing done: Built the plugin, loaded in a local Grafana and tested the following:
cloudAddrsetting