Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pixels-cache] recover radix tree in PixelsCacheWriter from index file. #72

Closed
bianhq opened this issue Sep 9, 2020 · 1 comment
Closed

[pixels-cache] recover radix tree in PixelsCacheWriter from index file. #72

bianhq opened this issue Sep 9, 2020 · 1 comment
Assignees
@bianhq
Labels
enhancement New feature or request

Comments

@bianhq
Copy link
Contributor

bianhq commented Sep 9, 2020

We should support recovering radix tree from index file in PixelsCacheWriter. So that the cache writer does not need to rebuild the in-memory radix tree structure after failover.

Besides, some memory allocations in the cache still need to be reduced.
@bianhq bianhq added the enhancement New feature or request label Sep 9, 2020
@bianhq bianhq self-assigned this Sep 9, 2020
bianhq added a commit that referenced this issue Sep 10, 2020
@bianhq
[Issue #72]: optimize memory allocation and access in PixelsCacheRead…
934b174 
…er. (#73)

1. eliminate the memory allocation for edge of nodes;
2. combine the memory read of edge and children into one.
bianhq added a commit that referenced this issue Sep 10, 2020
@bianhq
[Issue #72]: fix bugs in pixels-cache and implement loading radix fro…
f8ad798 
…m index file. (#77)

Fixed bugs:
1. RadixNode.addChild() does not maintain children size corrently;
2. RadixNode.getLengthInBytes() overrates nodesize;
3. allocatedIndexOffset in PixelsCacheWriter is not correctly maintained.

Loading radix from index file is implemented in PixelsCacheUtil.loadRadixIndex().
@bianhq
Copy link
Contributor Author

bianhq commented Sep 10, 2020

Resolved.

@bianhq bianhq closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bianhq bianhq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bianhq