Associate findings with changes or with new unfixed array #25
+39
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahsra
reviewed
Apr 3, 2024
drdavella
force-pushed
the
update-failure-reason
branch
from
27e8036
to
d483eba
Compare
drdavella
changed the title
drdavella
commented
Apr 5, 2024
| @@ -177,6 +182,10 @@ | |||
| "type": "array", | |||
| "description": "The package actions that were needed to support changes to the file", | |||
| "items": { "$ref": "#/definitions/packageAction" } | |||
| }, | |||
| "finding": { | |||
| "$ref": "#/definitions/detector/fixedFinding", | |||
There was a problem hiding this comment.
Still not sure whether this needs to be an array.
nahsra
approved these changes
Apr 8, 2024
nahsra
added a commit
to pixee/codemodder-java
that referenced
this pull request
Apr 8, 2024
This change populates CodeTF with new remediation metadata specified [here](pixee/codemodder-specs#25 (review)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For diagnostic and storytelling purposes, it is desirable for downstream consumers to know which findings are associated with which changes, and which findings were not fixed, where they were attempted, and for what reason.
This update includes the following modifications:
detectionToolno longer contains finding metadata. It is purely for metadata about the tool itself. Eventually we might add other fields likeversion,date, etc.changenow has afixedFindingpropertyresultthat represents unfixed findings, which include a reason for being unfixed