Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change test assertion to bypass python argparse bug #874

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Oct 10, 2024

Overview

Update log test assertion

There is a bug in python argparse starting in python3.12.7, which our pipeline has just now run across.
Argparse is incorrectly logging

            in caplog.messages
        )
E       AssertionError: assert 'CLI error: ambiguous option: --codemod=url-sandbox could match --codemod-exclude, --codemod-include' in ['CLI error: ambiguous option: *request.py could match --codemod-exclude, --codemod-include']

the ambiguous option the test passed is --codemod, not request.py which is what argparse is incorrectly logging

Updating this assertion is minimal impact for us.

Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit c0c3563 Oct 10, 2024
14 checks passed
@drdavella drdavella deleted the bypass-test branch October 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants