Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeTF: change descriptions are optional but must not be empty #822

Merged
merged 1 commit into from
Sep 5, 2024
Merged

CodeTF: change descriptions are optional but must not be empty #822

merged 1 commit into from
Sep 5, 2024

Conversation

drdavella
Copy link
Member

No description provided.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

clavedeluna
clavedeluna approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@clavedeluna clavedeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little confusing since "" is often the right sentinel value for empty str but I Get it

@drdavella drdavella added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 51344e5 Sep 5, 2024
13 checks passed
@drdavella drdavella deleted the change-string-nonblank branch September 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clavedeluna clavedeluna clavedeluna approved these changes

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdavella @clavedeluna