Implement codemod for sslcontext-minimum-version #19
Conversation
| @@ -122,3 +122,16 @@ def leave_Call(self, original_node: cst.Call, updated_node: cst.Call): | |||
| return new_node | |||
|
|
|||
| return updated_node | |||
|
|
|||
| def leave_Assign(self, original_node, updated_node): | |||
There was a problem hiding this comment.
Adding individual handlers like this does not feel like a viable long-term solution.
There was a problem hiding this comment.
The goal is that we're going to get to a point that we have all of these cases. Right now most (all?) our api based codemods related to a func/method call so leave_Call is appropriate. Your case is new so we need this. I think the django debug / session cookies codemods are similar and maybe we need to move those to the new api too
There was a problem hiding this comment.
I'm hoping that we can handle this via clever metaprogramming somehow (maybe with __getattr__?) rather than having to override each possible method explicitly.
There was a problem hiding this comment.
Yes, can be done with metaprogramming. Either use the __dict__ directly (and recursively over all the mro() classes), or use the getmembers from the inspect module.
There was a problem hiding this comment.
Yes that is another possibility. There are a variety of ways to approach this problem.
drdavella
force-pushed
the
sslcontext-minimum-version
branch
from
c93b7dd
to
9a92c04
Compare
drdavella
force-pushed
the
sslcontext-minimum-version
branch
from
9a92c04
to
0c31f47
Compare
drdavella
force-pushed
the
sslcontext-minimum-version
branch
from
0c31f47
to
0c5050c
Compare
Overview
Implement new codemod for
sslcontext-minimum-versionDescription
SSLContext.minimum_versionis set to an insecure version of SSL/TLSmaximum_versioncould also be set to a bad version. This is a bit of a philosophical question but it feels like that should be handled by a separate codemod