Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit LDAMallet wrapper from BaseModel to standardise print_topics #995

Merged
merged 2 commits into from
Nov 8, 2016
Merged

Inherit LDAMallet wrapper from BaseModel to standardise print_topics #995

merged 2 commits into from
Nov 8, 2016

Conversation

tmylk
Copy link
Contributor

@tmylk tmylk commented Nov 8, 2016

Continuing from #946

@tmylk tmylk merged commit 9a3329c into develop Nov 8, 2016
@tmylk
Copy link
Contributor Author

tmylk commented Dec 2, 2016 •
edited
Loading

Appveyor and osx builds are broken by this merge.
"cannot import unittests2"
Please skip the tests with skiptest instead of using unittest2

See https://ci.appveyor.com/project/piskvorky/gensim-431bq/build/job/rf9282gskvrf8n0q and https://travis-ci.org/MacPython/gensim-wheels/jobs/180761439

@piskvorky
Copy link
Owner

@tmylk you are the only participant in this issue -- who are you talking to?

@markroxor
Copy link
Contributor

@piskvorky it is addressed to me.

@markroxor
Copy link
Contributor

@tmylk shouldn't we add pip install unittests2 to the build config file instead of skipping?

@markroxor markroxor mentioned this pull request Dec 4, 2016
Merged
@tmylk tmylk mentioned this pull request Mar 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmylk @piskvorky @markroxor