Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #805: Added check in summarize_corpus #885

Merged
merged 6 commits into from
Sep 29, 2016
Merged

Fix Issue #805: Added check in summarize_corpus #885

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0157ab8
Added check in summarize_corpus to fix bug in summarizer
anmolgulati Sep 25, 2016
d74dc16
Fix #805: Added check in summarizing text
anmolgulati Sep 25, 2016
f24533b
Added test for checking low number of distinct words in text
anmolgulati Sep 28, 2016
990f70c
Text split method changed to allow running in Python 3.3 and above.
anmolgulati Sep 28, 2016
343b9a0
Change to fix test in python versions 3.3 and higher
anmolgulati Sep 28, 2016
df238ef
Added blank line test_wikicorpus.py file
anmolgulati Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gensim/summarization/summarizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ def summarize_corpus(corpus, ratio=0.2):
_set_graph_edge_weights(graph)
_remove_unreachable_nodes(graph)

# If the number of nodes < 3, the function ends.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a better comment explaining original error

if len(graph.nodes()) < 3:
logger.warning("Please add more sentences to the text. The number of reachable nodes is below 3")
return
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the function signature (Returns a list). Either raise an exception, or return an empty list -- this is just nasty unexpected gotcha for users.


pagerank_scores = _pagerank(graph)

hashable_corpus.sort(key=lambda doc: pagerank_scores.get(doc, 0), reverse=True)
Expand Down