Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed log message to warning as suggested in #828 #884

Merged
merged 2 commits into from
Sep 28, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Changes
[#879](https://github.com/RaRe-Technologies/gensim/pull/879))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete other comments in changelog.
Also please add this change to the future release 0.13.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Sorry for the bad commit. 👍

- bigram construction can now support multiple bigrams within one sentence
* Fixed issue #838, RuntimeWarning: overflow encountered in exp (@markroxor, [#895](https://github.com/RaRe-Technologies/gensim/pull/895))
* Changed some log messages to warnings as suggested in issue #828. (@rhnvrm, [#884](https://github.com/RaRe-Technologies/gensim/pull/884))


0.13.2, 2016-08-19

Expand Down
6 changes: 3 additions & 3 deletions gensim/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from __future__ import with_statement

import logging
import logging, warnings

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -836,7 +836,7 @@ def run(self):


if os.name == 'nt':
logger.info("detected Windows; aliasing chunkize to chunkize_serial")
warnings.warn("detected Windows; aliasing chunkize to chunkize_serial")

def chunkize(corpus, chunksize, maxsize=0, as_numpy=False):
for chunk in chunkize_serial(corpus, chunksize, as_numpy=as_numpy):
Expand Down Expand Up @@ -1011,7 +1011,7 @@ def has_pattern():
from pattern.en import parse
pattern = True
except ImportError:
logger.info("Pattern library is not installed, lemmatization won't be available.")
warnings.warn("Pattern library is not installed, lemmatization won't be available.")
return pattern


Expand Down