Added function to filter 'n' most frequent words #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! That is useful functionality to remove stop-words. |
|
I have added a quicktest and edited the CHANGELOG.txt file. Kindly check :) |
|
@abhinavchawla Great. Thanks for the PR! |
| logger.info("discarding %i tokens: %s...",len(most_frequent_ids), most_frequent_words[:10]) | ||
|
|
||
| self.filter_tokens(bad_ids=most_frequent_ids) | ||
| logger.info("resulting dictionary: %s" % self) |
There was a problem hiding this comment.
Use comma to pass parameters to logger, to avoid unnecessary string formatting for ignored events.
|
Added PEP8 and logger changes to develop. |
|
Hey sorry I was kinda busy and got time now :( Thanks a lot @tmylk :) Is there anything else to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that in filter_extremes function, they keep the 'n' most frequent word as provided in argument. I was asked by my professor to remove the 50 most frequent words in the dictionary and hence had to write my own code.
Therefore I have added a function which will filter out the 'n' most frequent words.