-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DTM example notebook #471
Conversation
What "the" dataset? I don't see any dataset anywhere -- what am I missing? It would be more instructive to show what kind of input DTM accepts. It looks like the notebook unpickles some file from a local disk (?) now, but I (the user) still have no idea what that is. Can you think of a way to make this clearer? Thanks! |
Ya it just basically loads up a normal gensim corpus + a time sequence array. Do you think embedding the pickled file inside the notebook will make it more clear? Its like basically an list of lists. I changed it a bit. Check if it's more understandable now. |
b01cbda
to
12a5706
Compare
Hey @Arttii , thanks for this. I ran it on my Fedora Linux no problem. |
@tmylk still some typos ("defentiion") and PEP8 nitpicks (space after comma, line break around Btw I've seen a message on the mailing list by @deakkon that it doesn't work, even with the @Arttii @tmylk I'd prefer to investigate and fix this thoroughly, before merging the tutorial. |
Unfortunately I couldn't reproduce @deakkon's mailing list issue on my Linux box. The wrapper works well for me on Linux. PEP8 and spelling updated in: |
I'll have you to check that. Sorry haven't had time recently. I'll take a look tomorrow maybe. From: Lev Konstantinovskiymailto:notifications@github.com Unfortunately I couldn't reproduce @deakkon's mailing list issue on my Linux box. The wrapper works well for me on Linux. PEP8 and spelling updated in: Reply to this email directly or view it on GitHub: |
Hi, Looks good. Sorry I didn't help out more some hectic work stuff. Artyom From: Lev Konstantinovskiymailto:notifications@github.com Hey @Arttii, is this ok to merge? Reply to this email directly or view it on GitHub: |
@Arttii Thanks a lot for adding the DTM wrapper! It seems to be used by a lot of people now. |
Hi,
Finally got around to doing this. I applied some pep8 to this and rearranged some stuff. Tell me if we need to change anything else.
Artyom