Enable install under poetry #3386
Conversation
Implement numpy hack in setup.py to enable install under Poetry piskvorky#3363
| __builtins__.__NUMPY_SETUP__ = False | ||
| except: | ||
| try: | ||
| # For python 3 |
There was a problem hiding this comment.
Gensim does not support python 2 any more.
There was a problem hiding this comment.
This is a PR against 3.8.3 which does support Python 2. I am happy to remove Python 2 support from the PR if that is an issue. The problem this solves is, install with Poetry (Python 3) fails for the the same reason as reference in #3363
There was a problem hiding this comment.
Oh, why are you making a PR against 3.8.3? We don't support it anymore, and won't be making any 3.8.x releases, right @piskvorky?
There was a problem hiding this comment.
Yes, of course. I didn't even notice the 3.8.3 branch :D
There was a problem hiding this comment.
I know it's not supported. But the Poetry install suddenly stopped working - same as in the develop branch. And for those of us that are still using it. This small PR fixes the issue.
There was a problem hiding this comment.
I think the best we can do is fix this on develop so future versions won't be affected.
Releasing a bugfix for 3.8.3 requires effort, the volume of which isn't justified, IMHO.
|
Closing, will not fix. |
Implement numpy hack in setup.py to enable install under Poetry #3363
This is the same as #3363 but on the 3.8.3 branch