Added "tensorflow.keras" compatibility in "KeyedVectors.get_keras_embedding" function.

[andrewsapw]

Since TensorFlow 2.0+, Keras is the part of TensorFlow library, so I added "from tensorflow.keras.layers import Embedding" as possible import to "Embedding" layer (the old way to import is allowed too) in "get_keras_embedding" function.

Fixes #2842 and closes #2729.

[piskvorky]

Thanks! A duplicate of #2729 (and #2842) but those are stale, so let's continue here.

[gojomo]

For the reasons listed in #2886, and in the spirit of #2873 (slim this module) & #2852 (reduce gensim surface area), I'd prefer to remove this one-line-of-recipe code from KeyedVectors.

It could easily live as a utility function elsewhere, or just be part of some example code in some doc/tutorial/notebook.

It's not inherent to the KeyedVectors type, and conditional-importing inside a method is a pretty bad 'code smell' indicating this is out-of-place.

[piskvorky]

That is true, though mostly orthogonal to this PR. We want both {modernize import, move fnc elsewhere}.

@andrewsapw as a user, where would you expect this function to live, were would you look for it first?
What's your use-case when calling it?

[andrewsapw]

That is true, though mostly orthogonal to this PR. We want both {modernize import, move fnc elsewhere}.

@andrewsapw as a user, where would you expect this function to live, were would you look for it first?
What's your use-case when calling it?

I agree that KeyedVectors if pretty big, and because of that it's not always obvious how to use it. On the other hand, this function is actual helpful for newbies, so mb gensim.utils is the right place for such small functions.
Regarding tutorials, it's hard to navigate there: plenty of notebooks and all kind of files (.png, .gif, .md and so on) in one place, so i think it can be reorganized to be more friendly to new people, maybe I can help with that.

[piskvorky]

Are you talking about the official tutorials, https://radimrehurek.com/gensim/auto_examples/index.html ?

Or what .png, .gif files?

[andrewsapw]

I meant https://github.com/RaRe-Technologies/gensim/tree/develop/docs/notebooks

[gojomo]

If it needs a module, maybe a new gensim.keras or gensim.integrations.keras. But really, since the functionality is just...

https://github.com/RaRe-Technologies/gensim/blob/4b7e372cf289b1bfa154db28a042618f96e91226/gensim/models/keyedvectors.py#L1619-L1627

...putting it in a "example of using gensim word-vectors with Keras" wiki page, or demo-notebook, would be just as understandable/discoverable as the existing utility function.