-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow name_only option gensim downloader api #2143
Merged
menshikh-iv
merged 35 commits into
piskvorky:develop
from
aneesh-joshi:name_only_develop
Aug 3, 2018
Merged
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
e249ed4
handle deprecation
aneesh-joshi 62f6c82
Merge branch 'develop' of https://github.com/RaRe-Technologies/gensim…
aneesh-joshi 1677e98
handle max_count
aneesh-joshi e8c08f8
change flag name
aneesh-joshi 258d033
make flake8 compatible
aneesh-joshi 875c65c
move max_vocab to prepare vocab
aneesh-joshi 0aa8426
correct max_vocab semantics
aneesh-joshi 390f333
remove unnecessary nextline
aneesh-joshi 8c508c7
fix bug and make flake8 complaint
aneesh-joshi c826b19
refactor code and change sorting to key based
aneesh-joshi 35dc681
add tests
aneesh-joshi 67f6a14
introduce effective_min_count
aneesh-joshi 7b1f612
make flake8 compliant
aneesh-joshi fafee70
remove clobbering of min_count
aneesh-joshi 9d99660
remove min_count assertion
aneesh-joshi 6c06fbc
.\gensim\models\word2vec.py
aneesh-joshi c5a0e6e
Revert ".\gensim\models\word2vec.py"
aneesh-joshi fdd2aab
rename max_vocab to max_final_vocab
aneesh-joshi 974d587
update test to max_final_vocab
aneesh-joshi ddb3556
move and modify comment docs
aneesh-joshi c54d8a9
make flake8 compliant
aneesh-joshi f379616
refactor word2vec.py
aneesh-joshi 46d3885
handle possible old model load errors
aneesh-joshi 2cf5625
include effective_min_count tests
aneesh-joshi 8578e3d
make flake compliant
aneesh-joshi a43fea3
remove check for max_final_vocab
aneesh-joshi 340a8cf
include backward compat for 3.3 models
aneesh-joshi 0b62407
remove unnecessary newline
aneesh-joshi 5b7a6c2
add test case for max_final_vocab
aneesh-joshi 48ad4dc
merge master
aneesh-joshi f282a56
Merge branch 'develop' of https://github.com/RaRe-Technologies/gensim…
aneesh-joshi 738a018
add name only option to downloader api
aneesh-joshi 3a91142
add tests
aneesh-joshi 2571e85
make single argument option for name_only
aneesh-joshi 0839f5c
make name_only into name
aneesh-joshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--info name
please :) (but stayname_only
parameter for CLI)