-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebooks #1893
Fix notebooks #1893
Conversation
@@ -933,106 +933,6 @@ | |||
" <th>100</th>\n", | |||
" <th>200</th>\n", | |||
" </tr>\n", | |||
" <tr>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I wasn't able to complete the execution of this cell as it was taking too long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't good, this information must be in this notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i will try running them again
" <th colspan=\"1\"></th>\n", | ||
" <th colspan=\"6\" style=\"text-align:center\"> Dimensions</th>\n", | ||
" </tr>\n", | ||
" <tr>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why diff here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't done manually, when i ran the notebook in the docker container the output might have been rendered differently.
@@ -1340,106 +1240,6 @@ | |||
" <th>100</th>\n", | |||
" <th>200</th>\n", | |||
" </tr>\n", | |||
" <tr>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this removed (and exactly same question for similar blocks after).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again this wasnt removed intentionally... the model was taking too long to run on my local system. I ended up just test running some of these cells(they are all working) and interrupting between. So the output is not present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as before #1893 (comment)
@@ -57,7 +57,7 @@ def word2vec2tensor(word2vec_model_path, tensor_filename, binary=False): | |||
outfiletsvmeta = tensor_filename + '_metadata.tsv' | |||
|
|||
with open(outfiletsv, 'w+') as file_vector: | |||
with open(outfiletsvmeta, 'w+') as file_metadata: | |||
with open(outfiletsvmeta, 'wb+') as file_metadata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this need? python3.5 problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%run ../../gensim/scripts/word2vec2tensor.py -i doc_tensor.w2v -o movie_plot
This line of code in Tensorboard_visualizations.ipynb
fails without this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check this script with other python versions (2.7
or 3.6
)? This is really suspicious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
Please move current commits to #1812 (see #1812 (comment)) |
As discussed in #1812