Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix made #1019 #1239

Closed
wants to merge 19 commits into from
Closed

Conversation

ArkadiyD
Copy link

@ArkadiyD ArkadiyD commented Mar 24, 2017

With parameter hs of model set to 0 there are no segmentation faults (Gensim 0.13.3, both Python 2. and 3. , proved with ddd). So, proposed hotfix is to turn off hs mode when model is upgraded.

For #1019

@tmylk
Copy link
Contributor

tmylk commented Mar 24, 2017

The segfault only happens in doc2vec codepath so this restriction is too strict.

@tmylk tmylk closed this Mar 24, 2017
@gojomo
Copy link
Collaborator

gojomo commented Mar 24, 2017

Also if someone intends a hierarchical-softmax model, and indeed has negative=0 so no negative-sampling happens, just turning off hs, making the model completely non-functional, is just breaking things a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants