word2vec2tensor with python 3 #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @tmylk in issue 1126, python 3 does not support word.encode('utf-8'). Changing to gensim.utils.to_unicode(word) worked. Tested with Python 3.5 in Ubuntu 16.04.
|
Thank you for the quick fix! |
|
That's not a good idea, please revert @tmylk . Never write unicode strings to output (or concatenate unicode and bytestrings with Always encode explicitly (here, to utf8) when serializing text data. |
|
Reverted in #1144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @tmylk in issue 1126, python 3 does not support
word.encode('utf-8'). Changing togensim.utils.to_unicode(word)worked. Tested with Python 3.5 in Ubuntu 16.04.