Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LdaSeqModel word probabilities (too rough rounding) #1480

Closed
menshikh-iv opened this issue Jul 11, 2017 · 6 comments
Closed

LdaSeqModel word probabilities (too rough rounding) #1480

menshikh-iv opened this issue Jul 11, 2017 · 6 comments

Comments

@menshikh-iv
Copy link
Contributor

Problem: Probabilities of words don't sum up to 1 because we have round(_, 3) in print_topic method
Solution: Remove round from print_topic from here

Based on message from maillist

@bhargavvader what's a reason to use round in this place?

@myrthevandieijen
Copy link

@menshikh-iv and @bhargavvader, thanks so much for looking into this issue! Do you have any idea when this problem will be fixed? Many thanks in advance!

@menshikh-iv
Copy link
Contributor Author

@myrthevandieijen It's very easy to fix, but I want to get an explanation from @bhargavvader about this behavior.

@bhargavvader
Copy link
Contributor

I really can't seem to remember why i had used round over here - can anyone make the fix and then see if the tests still pass fine?

@myrthevandieijen
Copy link

Any progress on this issue so far?Thanks!

@menshikh-iv
Copy link
Contributor Author

Fixed in #1547, @myrthevandieijen you can install gensim now from develop branch OR wait for next release (will be in September).

@myrthevandieijen
Copy link

myrthevandieijen commented Aug 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants